Skip to content

Add Stellar security detector rules for upgrade guards, symbol usage, access control, and cross-contract invocation#444

Merged
mijinummi merged 1 commit into
MDTechLabs:mainfrom
bellabuks:feature/stellar-security-detectors
Jun 2, 2026
Merged

Add Stellar security detector rules for upgrade guards, symbol usage, access control, and cross-contract invocation#444
mijinummi merged 1 commit into
MDTechLabs:mainfrom
bellabuks:feature/stellar-security-detectors

Conversation

@bellabuks
Copy link
Copy Markdown
Contributor

Summary

This PR adds four new static analysis detector rules under targeting common Soroban smart contract security and optimization issues.

Changes

  • rules/stellar/upgradeability/detect-missing-upgrade-guards.ts - Detects upgrade functions (, , ) that lack an admin authorization check, flagging contracts vulnerable to malicious upgrades.
  • rules/stellar/optimization/detect-inefficient-symbol-usage.ts - Detects repeated inline construction with the same name, suggesting static references to reduce execution overhead.
  • rules/stellar/access-control/detect-missing-access-control.ts - Detects privileged functions (, , , , etc.) that are missing a or equivalent role guard.
  • rules/stellar/cross-contract/detect-unsafe-cross-contract-invocation.ts - Detects cross-contract invocations (, , etc.) that lack caller validation or result verification.

closes #373
closes #374
closes #375
closes #378

… access control, and cross-contract invocation

- Detect missing upgrade guards on contract upgrade functions (MDTechLabs#373)
- Detect inefficient repeated Symbol construction patterns (MDTechLabs#374)
- Detect privileged functions lacking access control layers (MDTechLabs#375)
- Detect unsafe cross-contract invocations without validation (MDTechLabs#378)
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 2, 2026

@bellabuks Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mijinummi mijinummi merged commit 9a0fadd into MDTechLabs:main Jun 2, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants