Skip to content

feat: detect missing NatSpec and external calls in loops#428

Open
Leothosine wants to merge 5 commits into
MDTechLabs:mainfrom
Leothosine:fix/missing-natspec-external-calls-in-loops
Open

feat: detect missing NatSpec and external calls in loops#428
Leothosine wants to merge 5 commits into
MDTechLabs:mainfrom
Leothosine:fix/missing-natspec-external-calls-in-loops

Conversation

@Leothosine
Copy link
Copy Markdown
Contributor

Summary

  • Added MissingNatspecRule that flags public functions without NatSpec doc comments and suggests the @notice/@param/@return template.
  • Added ExternalCallsInLoopsRule that detects external calls (transfer/call/send/invoke) inside for/while loops and warns about gas and reentrancy risk.

Changes

  • packages/rules/src/auditability/docs/missing_natspec.rs
  • packages/rules/src/auditability/docs/mod.rs
  • packages/rules/src/auditability/mod.rs
  • packages/rules/src/security/external_calls/external_calls_in_loops.rs
  • packages/rules/src/security/external_calls/mod.rs

closes #316
closes #318

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 1, 2026

@Leothosine Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect External Calls Inside Loops Detect Missing NatSpec Documentation

1 participant