Feat/timestamp#426
Open
nafiuishaaq wants to merge 3 commits into
Open
Conversation
|
@nafiuishaaq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates implemented
Added a new Solidity rule
sol-013:name:Unsafe Timestamp Dependencycategory:securityseverity:highblock.timestampandnowusage in critical control flowImplemented the detection logic in:
Added regression tests in:
Notes
require(block.timestamp <= deadline, ...)anduint256 startTime = now;If you want, I can also add a dedicated fixture for
sol-013and/or update rule documentation.Made changes.
Closes #308
Done
Added a new tx.origin authentication rule for Solidity.
What changed
solidity-analyzer.ts
sol-014:name:Insecure tx.origin Authenticationseverity:highcategory:securitydescription: flagstx.originusage and suggestsmsg.senderdetectTxOriginUsage(code)tx.originusageanalyze(...)so findings are reportedsolidity-rules.spec.ts
tx.originauthentication usemsg.senderauthenticationNotes
Closes #309
tx.originusage is now flagged.Made changes.
Closes #306