release/v1.28.29 — dashboard edits show up on the way back; one scrollbar again#475
Merged
Conversation
…ne scrollbar again The third and final layer of the stale-tile bug: saving invalidated the dashboard snapshot with the default refetchType 'active', but the dashboard page is unmounted while the user sits in settings — the cell only went stale, and the snapshot query's deliberate refetchOnMount: false then suppressed the re-read on same-tab navigation back. The save, reset and ring mutations now invalidate with refetchType 'all', refreshing the cell mounted or not (proven live in one SPA session against the real query client). The sortable settings editors (dashboard layout, medication order, modules, mood tags x2) painted a second page scrollbar: the sr-only drag hint below each list is position: absolute, no ancestor was positioned, so it resolved against the initial containing block, escaped the shell's overflow clipping and lengthened the DOCUMENT by its static offset. The list wrappers are now relative; the e2e overscroll guard asserts the one-scroll-floor on these routes and was negative-tested against the revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both defects REPRODUCED with evidence before fixing.
Stale tiles, layer 3 (final) — invalidation used the default
refetchType: 'active'while the dashboard was unmounted; combined with the snapshot query's deliberaterefetchOnMount: false, same-tab back-navigation showed stale tiles until the poll/focus. The three mutations now invalidate withrefetchType: 'all'(unmounted cell refetches immediately — proven in a live SPA session). New test pins the defect shape, the fix, and the key-prefix matching;refetchOnMount: falseand the v1.28.28 focus-refetch stay as designed.Second scrollbar — the
sr-onlydrag hint (position: absolute) below every sortable list escaped to the initial containing block (no positioned ancestor) and lengthened the document by ~600px on /settings/layout/dashboard (html.scrollHeight 1500 vs 900 viewport, element-bisected). Fixed by making the five list wrappersrelative(dashboard layout, medication order, module order, mood tag manager + groups).e2e/settings-overscroll.spec.tsnow asserts the one-scroll-floor on these routes; negative-tested against the revert.Gate: typecheck, lint, 13490 unit tests, prettier, build, knip, openapi:check all green.