fix: theme handling in navbar component #236
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behaviour
When providing different logos in "appIcon" and "appIconDark" the logo is switched with switching of the theme.
Current behaviour
The "appIcon" was always return since the theme was always "undefined" and the handling of "auto" was also missing.
Steps to reproduce/test
in the root of the repo and the 2 mentioned SVGs in the "/frontend" subdirectory
None of this work was done using any type of LLM/AI.