Skip to content

Conversation

@skillpoint-dev
Copy link

Expected behaviour

When providing different logos in "appIcon" and "appIconDark" the logo is switched with switching of the theme.


Current behaviour

The "appIcon" was always return since the theme was always "undefined" and the handling of "auto" was also missing.


Steps to reproduce/test

overlayFSPath: '/etc/ots/assets'
appIcon: 'logo.svg'
appIconDark: 'logo_dark.svg'

in the root of the repo and the 2 mentioned SVGs in the "/frontend" subdirectory

<svg height="100" width="100" xmlns="http://www.w3.org/2000/svg">
  <circle r="45" cx="50" cy="50" fill="black" />
</svg>
<svg height="100" width="100" xmlns="http://www.w3.org/2000/svg">
  <circle r="45" cx="50" cy="50" fill="white" />
</svg>

None of this work was done using any type of LLM/AI.

Since theme was always undefined always the appIcon was returned. Besides that the handling of 'auto' wasn't included.

Signed-off-by: Skillpoint <25533353+skillpoint-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant