Resolve #108: Error & Toast Notification System#122
Merged
SudiptaPaul-31 merged 8 commits intoApr 26, 2026
Merged
Conversation
Contributor
Author
|
Collaborator
|
@Nacho1499 please resolve the conflicts |
Contributor
Author
|
conflict resolved |
Collaborator
|
@Nacho1499 build still failing |
- Add markAsDelivered method to WebSocketClient class - Expose markAsDelivered from useWebSocketSend hook - Resolves job 72926850335
Contributor
Author
|
CI issue resolved. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #108
PR Description:
This PR implements the centralized Error & Toast Notification system as defined in Issue #108. The goal was to replace raw technical errors with a consistent, user-friendly feedback loop across the application.
Changes implemented:
.Wallet not connected: Handled during authentication and message sending.
.Message send failed: Integrated into the WebSocket logic (includes rate-limit feedback).
.Network error: Handled via global onLine checks and WebSocket handshake failures.
Acceptance Criteria Verification:
[x] Toast notifications appear at top-right: Verified via global Toaster configuration.
[x] Consistent UI: All error triggers now route through a single utility.
[x] Wallet not connected: Handled in both the Connection flow and Messaging flow.
[x] Message send failed: Server-side errors and rate-limits are captured.
[x] Network error: Handled during initial socket connection and unexpected drops.
Testing Instructions:
-Wallet Flow: Open the wallet modal and reject the signature. Verify the "Wallet connection rejected" toast appears.
-Messaging Flow: Try to send a message while disconnected from the internet. Verify the "Network error" toast appears.
-Spam Protection: Send messages rapidly to trigger the rate limiter. Verify the toast displays the specific "Please wait X seconds" message.