Conversation
This adds automated build steps for the ESP32-S3 DevKit (esp32s3box environment) to the release workflow. When a release is published, it will now also build: - BE_<version>_ESP32-S3-DevKit.ota.bin (for OTA updates via web interface) - BE_<version>_ESP32-S3-DevKit.factory.bin (for initial flashing) The ESP32-S3 build uses: - 4MB flash size - esp32s3 chip - Same partition scheme as other environments (min_spiffs.csv) Users can download the .ota.bin file from GitHub releases and upload it via the web interface at http://<device-ip>/update 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The hal.h file was including <driver/gpio.h> unconditionally, which caused unit test compilation to fail since this ESP32-specific header doesn't exist in the test emulation environment. Wrapped the include with #ifndef UNIT_TEST to exclude it during tests. The CMakeLists.txt already defines UNIT_TEST for test builds. Fixes GitHub Actions unit test failures: - fatal error: driver/gpio.h: No such file or directory Verified builds still work: - esp32s3box: SUCCESS - lilygo_330: SUCCESS - compiler_warning_check: SUCCESS 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds full ESP32-S3 support to the Battery Emulator and merges the latest upstream changes from v10.2.dev (761 commits ahead). The implementation supports ESP32-S3 DevKit boards with MCP2515 CAN add-on and includes automated build/release workflows.
Changes
Hardware Support
esp32s3boxenvironment)USER_SETTINGS_ESP32S3.hBuild System
espressif32platform from 6.12.0 to 6.13.0ESP-IDF 5.x API Updates
Fixed ESP32-S3 API compatibility issues discovered during merge:
Watchdog API (Software.cpp):
LEDC PWM API (comm_contactorcontrol.cpp, precharge_control.cpp):
ledcAttachChannel()(ESP-IDF 5.x)ledcSetup()/ledcAttachPin()conditionalsMQTT Configuration (mqtt.cpp):
mqtt_cfg.broker.address.*andmqtt_cfg.credentials.*I2C Display (display.cpp):
Unit Tests (hal.h):
#ifndef UNIT_TESTTesting
Verified Builds
esp32s3box- ESP32-S3 DevKit (NEW)lilygo_330- LilyGo T-CAN485lilygo_2CAN_330- LilyGo T-2CANstark_330- Stark CMRcompiler_warning_check- Strict warnings checkHardware Tested
Upstream Merge
Merged 761 commits from upstream v10.2.dev including:
Release Automation
GitHub Actions now automatically builds ESP32-S3 binaries on release:
BE_<version>_ESP32-S3-DevKit.ota.bin- OTA update fileBE_<version>_ESP32-S3-DevKit.factory.bin- Full flash imageBreaking Changes
None - all existing boards remain fully compatible.
Notes
http://<device-ip>/updateRelated Issues