Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! μ΄λ² PRμ μ΄λ―Έμ§ μ λ‘λ κΈ°λ₯μ μμ μ±μ λμ΄κΈ° μν 11μ°¨ λ°°ν¬ μμ μ λλ€. μ λ‘λ μ ν μ©λμ μ΅μ ννκ³ , κ΄λ ¨ μλ¬ λ©μμ§κ° μ€μ λ μμ«κ°μ λμ μΌλ‘ λ°μνλλ‘ κ°μ νμ¬ μ½λμ μΌκ΄μ±κ³Ό κ΄λ¦¬ ν¨μ¨μ±μ λμμ΅λλ€. Highlights
New Featuresπ§ You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
μ΄λ² ν 리νμ€νΈμμλ μ΄λ―Έμ§ μ λ‘λ μ΅λ μ©λμ 5MBμμ 4MBλ‘ λ³κ²½νκ³ , μλ¬ λ©μμ§μμ ν΄λΉ μ©λμ λμ μΌλ‘ κ³μ°νλλ‘ μμ νμμ΅λλ€. 리뷰λ₯Ό ν΅ν΄ 1024 * 1024μ κ°μ λ§€μ§ λλ²λ₯Ό MB μμλ‘ μΆμΆνμ¬ κ°λ μ±μ λμ΄κ³ , μλ¬ λ©μμ§ κ³μ° μμλ μ΄λ₯Ό νμ©νμ¬ μ½λμ μΌκ΄μ±κ³Ό μ μ§λ³΄μμ±μ κ°μ νλΌλ νΌλλ°±μ΄ μ μλμμ΅λλ€.
| export const IMAGE_RULES = { | ||
| MAX_SIZE: 5 * 1024 * 1024, // 5MB | ||
| MAX_SIZE: 4 * 1024 * 1024, // 4MB |
There was a problem hiding this comment.
1024 * 1024μ κ°μ λ§€μ§ λλ²λ₯Ό MBμ κ°μ μμλ‘ μΆμΆνμ¬ κ°λ
μ±μ λμ΄κ³ , μ€λ³΅λ μ£Όμ(// 4MB)μ μ κ±°νλ κ²μ΄ μ’μ΅λλ€. μ΄λ κ² νλ©΄ λμ€μ μ©λ μ νμ΄ λ³κ²½λλλΌλ ν κ³³λ§ μμ νλ©΄ λλ―λ‘ μ μ§λ³΄μκ° μ©μ΄ν΄μ§λλ€.
const MB = 1024 * 1024;
export const IMAGE_RULES = {
MAX_SIZE: 4 * MB,References
- κ°λ μ± λμ μ½λλ₯Ό μ§ν₯νλ©°, λ°λ³΅λλ λ§€μ§ λλ²λ₯Ό μμλ‘ κ΄λ¦¬νμ¬ μ μ§λ³΄μμ±μ ν₯μμν΅λλ€. (link)
| */ | ||
| export const IMAGE_ERROR_MESSAGES = { | ||
| IMAGE_SIZE_EXCEEDED: 'μ΄λ―Έμ§ μ©λμ 5MBλ₯Ό μ΄κ³Όν μ μμ΅λλ€', | ||
| IMAGE_SIZE_EXCEEDED: `μ΄λ―Έμ§ μ©λμ ${IMAGE_RULES.MAX_SIZE / (1024 * 1024)}MBλ₯Ό μ΄κ³Όν μ μμ΅λλ€`, |
There was a problem hiding this comment.
μμμ μ μν MB μμλ₯Ό νμ©νμ¬ μλ¬ λ©μμ§λ₯Ό μμ±νλλ‘ κ°μ ν μ μμ΅λλ€. μ΄λ₯Ό ν΅ν΄ μ½λμ μλλ₯Ό λ λͺ
ννκ² μ λ¬νκ³ μΌκ΄μ±μ μ μ§ν μ μμ΅λλ€.
| IMAGE_SIZE_EXCEEDED: `μ΄λ―Έμ§ μ©λμ ${IMAGE_RULES.MAX_SIZE / (1024 * 1024)}MBλ₯Ό μ΄κ³Όν μ μμ΅λλ€`, | |
| IMAGE_SIZE_EXCEEDED: `μ΄λ―Έμ§ μ©λμ ${IMAGE_RULES.MAX_SIZE / MB}MBλ₯Ό μ΄κ³Όν μ μμ΅λλ€`, |
References
- κ°λ μ± λμ μ½λλ₯Ό μ§ν₯νλ©°, μΌκ΄λ μμ μ¬μ©μ ν΅ν΄ μ½λμ λͺ νμ±μ λμ λλ€. (link)
μ΄λ―Έμ§ μ©λ μλ¬ μ²λ¦¬ μμ ν λ°°ν¬