Skip to content

[🚨 QA/#389] 이미지 μ—…λ‘œλ“œ μš©λŸ‰ μ΅œλŒ€ 4MB ν•˜ν–₯ μ‘°μ •#390

Merged
Lseojeong merged 2 commits into
devfrom
qa/#389
May 19, 2026
Merged

[🚨 QA/#389] 이미지 μ—…λ‘œλ“œ μš©λŸ‰ μ΅œλŒ€ 4MB ν•˜ν–₯ μ‘°μ •#390
Lseojeong merged 2 commits into
devfrom
qa/#389

Conversation

@bitna0a

@bitna0a bitna0a commented May 19, 2026

Copy link
Copy Markdown
Collaborator

#οΈβƒ£μ—°κ΄€λœ 이슈

체크 사항

  • [] UI λ™μž‘ 및 λ ˆμ΄μ•„μ›ƒ 확인
  • μ½˜μ†” 둜그/μ—λŸ¬ μ—†μŒ
  • κΈ°λŠ₯ 정상 λ™μž‘
  • νŒ€ μ»¨λ²€μ…˜μ— 맞게 κ΅¬ν˜„ν–ˆλŠ”μ§€

πŸ“μž‘μ—… λ‚΄μš©

이번 PRμ—μ„œ μž‘μ—…ν•œ λ‚΄μš©μ„ κ°„λž΅νžˆ μ„€λͺ…ν•΄μ£Όμ„Έμš”(이미지 첨뢀 κ°€λŠ₯)

이미지 μ—…λ‘œλ“œ μƒμˆ˜ λ³€κ²½

  • IMAGE_RULES.MAX_SIZE λ‹¨μœ„λ₯Ό 4 * 1024 * 1024 (4MB)둜 ν•˜ν–₯ μ‘°μ •
  • μ—λŸ¬ λ©”μ‹œμ§€λ„ 이미지 μš©λŸ‰μ€ 4MBλ₯Ό μ΄ˆκ³Όν•  수 μ—†μŠ΅λ‹ˆλ‹€λ‘œ 동기화

μœˆλ„μš°λŠ” 2μ§„λ²•μœΌλ‘œ κ³„μ‚°ν•΄μ„œ 화면에 ν‘œμ‹œλœ 4MBκ°€ λ‚΄λΆ€ 검사 κΈ°μ€€κ³Ό μΌμΉ˜ν•˜μ§€λ§Œ, λ§₯뢁은 10진법을 μ‚¬μš©ν•˜κΈ° λ•Œλ¬Έμ— 화면에 ν‘œμ‹œλœ μš©λŸ‰κ³Ό μ‹€μ œ μ½”λ“œμ—μ„œ κ³„μ‚°ν•˜λŠ” μš©λŸ‰ 간에 μ˜€μ°¨κ°€ λ°œμƒν•¨. ν…ŒμŠ€νŠΈ κ²°κ³Ό macOSμ—μ„œ '4.2MB'둜 ν‘œκΈ°λœ 파일 -> μ‹€μ œ κ³„μ‚°λœ 크기 '4.02MB'μ΄μ˜€μœΌλ©°, 이 파일이 μœ νš¨μ„± 검사λ₯Ό ν†΅κ³Όν•˜λŠ” κ±Έ ν™•μΈν•˜κ³  μ—…λ‘œλ“œ μ΅œλŒ€ ν—ˆμš© μš©λŸ‰μ„ 4MB둜 ν•˜ν–₯ μ‘°μ •ν•˜μ—¬, OS ν™˜κ²½μ— 상관없이 μ˜λ„ν•œ μš©λŸ‰ μ œν•œμ΄ μ •ν™•νžˆ μž‘λ™ν•˜λ„λ‘ μˆ˜μ •ν•¨.

μŠ€ν¬λ¦°μƒ· (선택)

image image image

μΆ”κ°€ν•œ 라이브러리 (선택)

πŸ’¬λ¦¬λ·° μš”κ΅¬μ‚¬ν•­(선택)

리뷰어가 νŠΉλ³„νžˆ λ΄μ£Όμ—ˆμœΌλ©΄ ν•˜λŠ” 뢀뢄이 μžˆλ‹€λ©΄ μž‘μ„±ν•΄μ£Όμ„Έμš”

ex) λ©”μ„œλ“œ XXX의 이름을 더 잘 μ§“κ³  싢은데 ν˜Ήμ‹œ 쒋은 λͺ…칭이 μžˆμ„κΉŒμš”?

@bitna0a bitna0a requested a review from Lseojeong May 19, 2026 12:46
@bitna0a bitna0a self-assigned this May 19, 2026
@bitna0a bitna0a added the 🚨 Bug 버그 발견/ν•΄κ²° label May 19, 2026
@vercel

vercel Bot commented May 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bookscape Ready Ready Preview, Comment May 19, 2026 1:01pm

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

λ³Έ PR은 이미지 μ—…λ‘œλ“œ μ‹œ ν—ˆμš©λ˜λŠ” μ΅œλŒ€ μš©λŸ‰μ„ 5MBμ—μ„œ 4MB둜 λ³€κ²½ν•˜μ—¬ μ‹œμŠ€ν…œμ˜ λ¦¬μ†ŒμŠ€ 관리 νš¨μœ¨μ„ λ†’μ΄κ³ μž ν•©λ‹ˆλ‹€. OS별 파일 크기 계산 λ°©μ‹μ˜ 차이λ₯Ό κ³ λ €ν•˜μ—¬ ν…ŒμŠ€νŠΈλ₯Ό 거친 ν›„ μ΅œμ ν™”λœ μš©λŸ‰ μ œν•œμ„ μ μš©ν•˜μ˜€μœΌλ©°, 이에 λ”°λ₯Έ μ—λŸ¬ λ©”μ‹œμ§€ 문ꡬ도 ν•¨κ»˜ λ™κΈ°ν™”ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

Highlights

  • 이미지 μ—…λ‘œλ“œ μš©λŸ‰ μ œν•œ μ‘°μ •: 이미지 μ—…λ‘œλ“œ μ΅œλŒ€ μš©λŸ‰μ„ κΈ°μ‘΄ 5MBμ—μ„œ 4MB둜 ν•˜ν–₯ μ‘°μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • μ—λŸ¬ λ©”μ‹œμ§€ μ—…λ°μ΄νŠΈ: μš©λŸ‰ μ œν•œ 변경에 맞좰 μ‚¬μš©μžμ—κ²Œ ν‘œμ‹œλ˜λŠ” μ—λŸ¬ λ©”μ‹œμ§€λ₯Ό 4MB κΈ°μ€€μœΌλ‘œ μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 ν’€ λ¦¬ν€˜μŠ€νŠΈμ—μ„œλŠ” 이미지 μ—…λ‘œλ“œ μ΅œλŒ€ μš©λŸ‰ μ œν•œμ„ 5MBμ—μ„œ 4MB둜 λ³€κ²½ν•˜κ³ , 이에 맞좰 μ—λŸ¬ λ©”μ‹œμ§€ λ‚΄μ˜ ν…μŠ€νŠΈλ₯Ό μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€. 리뷰λ₯Ό 톡해 ν•˜λ“œμ½”λ”©λœ μ—λŸ¬ λ©”μ‹œμ§€λ₯Ό MAX_SIZE μƒμˆ˜λ₯Ό ν™œμš©ν•˜μ—¬ λ™μ μœΌλ‘œ μƒμ„±ν•˜λ„λ‘ κ°œμ„ ν•˜λŠ” μ œμ•ˆμ΄ μžˆμ—ˆμŠ΅λ‹ˆλ‹€. μ΄λŠ” Single Source of Truth 원칙을 μ€€μˆ˜ν•˜μ—¬ ν–₯ν›„ μœ μ§€λ³΄μˆ˜ μ‹œ λ°œμƒν•  수 μžˆλŠ” 데이터 뢈일치 문제λ₯Ό λ°©μ§€ν•˜λŠ” 데 도움이 λ©λ‹ˆλ‹€.

Comment thread src/shared/constants/file.ts Outdated
@github-actions

Copy link
Copy Markdown

🎨 μŠ€ν† λ¦¬λΆ 배포 링크 확인

@github-actions

Copy link
Copy Markdown

🎨 μŠ€ν† λ¦¬λΆ 배포 링크 확인

@bitna0a bitna0a left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ œλ―Έλ‚˜μ΄ μ½”λ“œλ¦¬λ·° λ°˜μ˜ν–ˆμŠ΅λ‹ˆλ‹Ή

@Lseojeong Lseojeong left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€! μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹Ή

@Lseojeong Lseojeong merged commit 1b5946a into dev May 19, 2026
6 checks passed
@Lseojeong Lseojeong deleted the qa/#389 branch May 19, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 Bug 버그 발견/ν•΄κ²°

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🚨BUG] 이미지 μ—…λ‘œλ“œ μ΅œλŒ€ ν—ˆμš© μš©λŸ‰ ν•˜ν–₯ μ‘°μ •

2 participants