fix: search full keyword tree before creating duplicates#216
Closed
Olioli4 wants to merge 1 commit into
Closed
Conversation
When the LLM returns a keyword at root level that already exists in a hierarchy branch (e.g. 'Fruehling' exists under 'Jahreszeiten'), findKeywordByNameInParent() fails to find it because it only searches under the given parent. This causes duplicate keywords at root level. Add findKeywordInFullTree() that recursively traverses the entire catalog tree and caches the name-to-keyword index per session. Use it as a fallback in resolveAndAttachKeyword() before creating a new keyword. Refs: LrGenius#214
Author
|
Closing - the fix does not work as expected. The full-tree search approach has issues with Lightroom SDK keyword resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the LLM returns a keyword at root level (not nested under a hierarchy category),
findKeywordByNameInParent()only searches under the given parent (or root when parent is nil). It never finds the keyword if it already exists deeper in the catalog hierarchy, causing a duplicate to be created at root level.Changes
Plugin (Lua)
findKeywordInFullTree()that recursively traverses the entire catalog tree by name. Used as a fallback inresolveAndAttachKeyword()before creating a new keyword. The name-to-keyword index is cached per session for performance.Related Issues
Closes #214