fix: send catalog keyword vocabulary from plugin to backend#215
Closed
Olioli4 wants to merge 1 commit into
Closed
Conversation
The backend already supports catalog_keywords but the Lua plugin never populated this field via collectCatalogKeywordNames(). Also add deduplication and catalog name normalization in _normalize_keywords_structure() so that duplicate or differently-cased keywords are collapsed before reaching LR. Refs: LrGenius#213
Author
|
Closing - approach needs to be rethought. Keeping the issues open for discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The backend already supports sending the full catalog keyword vocabulary to the LLM via the
catalog_keywordsfield inMetadataGenerationRequest, and injects it into the prompt. However, the Lua plugin never populated this field.Changes
Plugin (Lua)
MetadataManager.collectCatalogKeywordNames()(limit 500) and pass asoptions.catalog_keywordsBackend (Python)
_normalize_keywords_structure): Added deduplication (case-insensitive) and catalog name normalization within the response. If the LLM returns "fruehling" and the catalog has "Fruehling", the canonical catalog spelling is usedrequest.catalog_keywordsto the normalization functionRelated Issues
Closes #213