Skip to content

Fix SSL and token issues#13

Open
jussihi wants to merge 3 commits into
LouisPlisso:masterfrom
jussihi:master
Open

Fix SSL and token issues#13
jussihi wants to merge 3 commits into
LouisPlisso:masterfrom
jussihi:master

Conversation

@jussihi
Copy link
Copy Markdown

@jussihi jussihi commented Oct 4, 2019

This PR fixes the missing SSL support and renames "token" to "account_playback_token" inside the video_info struct.

These fixes were needed to make pytomo work when this PR was created.

Copy link
Copy Markdown

@jacksgt jacksgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - looks good!

@jacksgt
Copy link
Copy Markdown

jacksgt commented Oct 6, 2019

Hey, so I just tested the PR, but I'm still getting the same error. Do I need to add any parameter when crawling?

./start_crawl.py --no-related https://www.youtube.com/watch?v=iTMyV8UhSi0
...
2019-10-06 16:17:24,392 - start_pytomo.py:860 - DEBUG - input_links: set(['https://www.youtube.com/watch?v=vwIUJbIU57s'])
2019-10-06 16:17:24,393 - start_pytomo.py:757 - DEBUG - Crawl of url# 0: https://www.youtube.com/watch?v=vwIUJbIU57s
2019-10-06 16:17:24,393 - lib_youtube_download.py:288 - DEBUG - instanciate a Youtube FileDownloader with download_time: 30.0
2019-10-06 16:17:24,393 - lib_general_download.py:189 - DEBUG - Max download_time is: 30
2019-10-06 16:17:24,395 - lib_youtube_download.py:293 - DEBUG - Download webpage vwIUJbIU57s
2019-10-06 16:17:24,746 - lib_general_download.py:374 - DEBUG - trouble message: ERROR: YouTube said: HTTP is not supported.
2019-10-06 16:17:24,747 - lib_youtube_download.py:319 - ERROR - ERROR: YouTube said: HTTP is not supported.

@jussihi
Copy link
Copy Markdown
Author

jussihi commented Oct 6, 2019

@jacksgt with current state of the code I don't encounter that error at all. I added forcing of https as a new commit, could you test it..?

video_url_list = None
#req_format = self._downloader.params.get('format', None)
get_video_template = ('http://www.youtube.com/get_video?'
get_video_template = ('https://www.youtube.com/get_video?'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the line I still needed :-)

@jacksgt
Copy link
Copy Markdown

jacksgt commented Oct 6, 2019

@jussihi Thank you, with the added HTTPS enforcement it works - now I can actually start working on the assignment ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants