feat: throne of miscellania and managing miscellania#528
Open
ovenbreado wants to merge 26 commits into
Open
Conversation
Contributor
Author
|
I think I've done the whole series of stuff including
let me know if there's other stuff. https://www.youtube.com/watch?v=ePFcUgLqdVg - Have you got a copy of my book 10:19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've written this for 09, https://gitlab.com/2009scape/2009scape/-/merge_requests/2030 which is the process of being complete after a years worth of research. I'd thought it would be nice to reflect that work in LostCity too seeing that the next update would need this in version 289.
One thing to mention is that I've based it exclusively off YouTube videos, so if you do have other suggestions and or fixes, please let me know.
One huge difference with the current implementation (osrs/rs3) is that things are now made to be gender neutral. I have not implemented that to stay true to the older versions which were male-marryprincess female-marryprince and that switching gender midway would reset progress unless the quest is completed fully. This is just to be authentic to the era and is not meant to offend anyone. That said, lots of text are transcribed from videos and are not from the wiki, so do double check with sources if you do find any discrepancies (e.g. modern its sir/madam, but 2005 it was Sir/Madam capitalized).
Managing Miscellania is going to flood the market with resources and change a lot of things, so the values I've used here are conservative until proven otherwise. Definitely up for discussion.
Otherwise, please enjoy this contribution. This is also a tribute to a lovely 09 discord user Baruch who has unfortunately passed away due to cancer, and who I've dedicated this 09 quest implementation to while the user was alive battling cancer. Rest in Peace.