Skip to content

Address remaining PR #158 review comments (all fixed in de6db84)#160

Closed
Copilot wants to merge 1 commit intodevelopfrom
copilot/sub-pr-158-again
Closed

Address remaining PR #158 review comments (all fixed in de6db84)#160
Copilot wants to merge 1 commit intodevelopfrom
copilot/sub-pr-158-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

PR #158 was merged before all reviewer comments were actioned. All five outstanding items were addressed in PR #159 (commit de6db84), which is already included in this branch.

Changes (de6db84)

  • brief-intent.tsderiveSeedIds() now normalizes relative editedFilePath to absolute via path.isAbsolute() / path.join(workspaceRoot, ...) before calling getSourceLinkedRequirementIds(), fixing silent [] returns when file.edited emits a relative path
  • index.tscomputeBriefIntent() called once in file.edited handler; fingerprint cached in lastBriefFingerprint. system.transform hook reads from cache instead of recomputing — eliminates redundant symbols.yaml I/O on every transform
  • Docs – Removed accidental #YT|> annotation prefixes from REQ-opencode-kibi-briefing-v1.md, SCEN-opencode-kibi-briefing-v1.md, and TEST-opencode-kibi-briefing-v1.md
// Before: relative path passed directly, silently returns []
return getSourceLinkedRequirementIds(params.workspaceRoot, params.editedFilePath)

// After: normalized to absolute before lookup
const absoluteEditedPath = path.isAbsolute(params.editedFilePath)
  ? params.editedFilePath
  : path.join(params.workspaceRoot, params.editedFilePath);
return getSourceLinkedRequirementIds(params.workspaceRoot, absoluteEditedPath)

Copilot AI changed the title [WIP] Enhance auto briefing functionality and documentation for v2 Address remaining PR #158 review comments (all fixed in de6db84) Apr 23, 2026
Copilot AI requested a review from Looted April 23, 2026 16:01
@Looted Looted closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants