Skip to content

feat(web): add SolidJS integration guide and example#2

Merged
cmelgarejo merged 1 commit into
mainfrom
chore/port-opos-improvements
Mar 20, 2026
Merged

feat(web): add SolidJS integration guide and example#2
cmelgarejo merged 1 commit into
mainfrom
chore/port-opos-improvements

Conversation

@cmelgarejo
Copy link
Copy Markdown
Member

  • Created docs/SOLIDJS_INTEGRATION.md\n- Scaffolded web/solid-example with Vite + SolidTS\n- Implemented api.ts and premium App.tsx with Wow Factor\n- Generated custom modulith_hero image

- Created docs/SOLIDJS_INTEGRATION.md\n- Scaffolded web/solid-example with Vite + SolidTS\n- Implemented api.ts and premium App.tsx with Wow Factor\n- Generated custom modulith_hero image
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0425b4799

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

import solidLogo from './assets/solid.svg'
import viteLogo from './assets/vite.svg'
import heroImg from './assets/hero.png'
import { fetchCurrentUser, setupEventsWebSocket, User } from './api'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Import User with a type-only import

This import breaks the TypeScript build because User is an interface, but it is imported as a runtime symbol while verbatimModuleSyntax is enabled in web/solid-example/tsconfig.app.json; npm run build executes tsc -b, which will raise TS1484 unless User is imported via import type. As written, the new example cannot compile successfully.

Useful? React with 👍 / 👎.

</p>
<div class="action-buttons">
<a href="https://github.com/LoopContext/go-modulith-template" class="btn primary">View Template</a>
<button class="btn secondary" onClick={() => window.open('/docs/SOLIDJS_INTEGRATION.md')}>Read Guide</button>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Link the guide button to a served path

The Read Guide button opens /docs/SOLIDJS_INTEGRATION.md, but in this Vite app only files under web/solid-example/public (and the built bundle) are served, so this path 404s in npm run dev and typical static deployments of this example. Users clicking the CTA from the demo won’t reach the integration guide.

Useful? React with 👍 / 👎.

@cmelgarejo cmelgarejo merged commit 7b0abef into main Mar 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant