Disable automatic reload#149
Open
97saundersj wants to merge 5 commits into
Open
Conversation
Introduced a new configuration setting 'DisableEmptyMagazineAutoReload' to prevent automatic reloading when firing with an empty magazine. Updated input handling to respect this setting and added a helper function to determine when to suppress firing to avoid unintended reloads.
…tion Updated the 'DisableEmptyMagazineAutoReload' configuration description for clarity. Removed the 'MaybeSuppressEmptyMagAutoReload' function and its references from the input handling logic, as it is no longer needed. This streamlines the code and improves maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a new setting
DisableEmptyMagazineAutoReloadwhich when enabled will disable the games automatic reloading when a magazine is out of ammo.When the magazine is out of ammo the player will have to manually press the reload button, which will then play the reload animation and reload the weapon.
When the magazine is empty and the player tries to fire the sound and reload UI will be shown, just like when a weapon is fully out of ammo.
Demo
797bca7cc039f92c000aec718237e2e02.mp4
Files for testing:
HaloCEVR.zip
I have tested with all in game weapons and it seems to work well.
Any feedback is welcome :)