Skip to content

DATA-46376 Use matcher to determine when to apply EID permissions, instead of source names, to avoid collisions with unrelated traffic and ensure we only permission IDs we enrich.#2

Open
peixunzhang wants to merge 14 commits into
masterfrom
DATA-46376
Open

DATA-46376 Use matcher to determine when to apply EID permissions, instead of source names, to avoid collisions with unrelated traffic and ensure we only permission IDs we enrich.#2
peixunzhang wants to merge 14 commits into
masterfrom
DATA-46376

Conversation

@peixunzhang
Copy link
Copy Markdown

@peixunzhang peixunzhang commented Apr 26, 2026

Update permissions logic to use matcher field as the authoritative condition for applying EID permissions.

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@peixunzhang peixunzhang self-assigned this Apr 26, 2026
@peixunzhang peixunzhang requested a review from SuperIzya April 27, 2026 09:58
@peixunzhang peixunzhang marked this pull request as ready for review April 27, 2026 14:37
@peixunzhang peixunzhang force-pushed the DATA-46376 branch 2 times, most recently from f0339e7 to 74a4959 Compare May 4, 2026 08:30
Use matcher to determine when to apply EID permissions, instead of source names, to avoid collisions with unrelated traffic and ensure we only permission IDs we enrich.:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants