This repository was archived by the owner on May 11, 2026. It is now read-only.
Conversation
3link
reviewed
May 31, 2024
| }); | ||
| // If existing userId modules were present, then we need to explicitly refresh the newly added module | ||
| if (existingConfig.userSync.userIds.length > 1) { | ||
| pbjs.refreshUserIds({ submoduleNames: ["liveIntentId"] }); |
3link
approved these changes
May 31, 2024
| if ((window.liTreatmentRate || 0) < LI_TREATMENT_RATE && !window.liModuleEnabled) { | ||
| // If a previous wrapper set a lower treatment rate, adjust the probability to upgrade | ||
| // and re-flip if needed. Otherwise, match LI_TREATMENT_RATE. | ||
| const treatment_rate = 1 - (1 - LI_TREATMENT_RATE) / (1 - (window.liTreatmentRate || 0)); |
There was a problem hiding this comment.
Please correct me if i am wrong. I think we decided to declare one holdout by the first script and keep it uniform for all the scripts and discussed that we could make the holdout 98-2 or 97-3 instead of 95-5 if we feel 95-5 is too high. That way the holdout percentage is uniform and transparent to everyone and no one is surprised at the time of billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.