Data 36553 include ad size as a field that in the data collected by the client side analytics adapter#70
Closed
zeta-xiao wants to merge 57 commits into
Conversation
…ing bid analytics on auction init event
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…-in-the-data-collected-by-the-client-side-analytics-adapter
zeta-xiao
force-pushed
the
DATA-36553-include-ad-size-as-a-field-that-in-the-data-collected-by-the-client-side-analytics-adapter
branch
from
eefd404 to
d22039a
Compare
Bumps [glob](https://github.com/isaacs/node-glob) from 10.4.5 to 10.5.0. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v10.4.5...v10.5.0) --- updated-dependencies: - dependency-name: glob dependency-version: 10.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Bumps [axios](https://github.com/axios/axios) from 1.9.0 to 1.13.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.9.0...v1.13.2) --- updated-dependencies: - dependency-name: axios dependency-version: 1.13.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
zeta-xiao
force-pushed
the
DATA-36553-include-ad-size-as-a-field-that-in-the-data-collected-by-the-client-side-analytics-adapter
branch
from
2acdca2 to
b89fcab
Compare
zeta-xiao
force-pushed
the
DATA-36553-include-ad-size-as-a-field-that-in-the-data-collected-by-the-client-side-analytics-adapter
branch
from
b89fcab to
e09bac7
Compare
SuperIzya
approved these changes
Nov 20, 2025
* local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * Cache deps
No longer needed in 10
* test arguments * declare environ * environment name * I like secrets * Revert "I like secrets" This reverts commit dc07a6a. * try getPRProperties * local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * test integration * self-contained workflow * Cache deps * Install dependencies * pass PR number * WIP pr bot * Update PR assignment script * typo * undo unrelated change
* test arguments * declare environ * environment name * I like secrets * Revert "I like secrets" This reverts commit dc07a6a. * try getPRProperties * local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * test integration * self-contained workflow * Cache deps * Install dependencies * pass PR number * WIP pr bot * Update PR assignment script * typo * undo unrelated change * look at reviews as well as requested reviewers * add an extra authorized reviewer check * Do not consider negative engineers
* test arguments * declare environ * environment name * I like secrets * Revert "I like secrets" This reverts commit dc07a6a. * try getPRProperties * local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * test integration * self-contained workflow * Cache deps * Install dependencies * pass PR number * WIP pr bot * Update PR assignment script * typo * undo unrelated change * look at reviews as well as requested reviewers * add an extra authorized reviewer check * Do not consider negative engineers * do not request reviewers that have already reviewed
…4143) * Read currency configs * Add tests for the currency handling
* local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * try to install chrome 109 * log browsers * deb installation * fix deb installation * extract install-deb * fix install-deb * more flexible version definition * remove safari 15 * disable coverage on chrome 109 * Better job names * bump chrome 109 -> 113, and add logic to test it outside browserstack * reintroduce safari 15.6 * try --no-sandbox * rename custom -> noSandbox * update wait for browserstack to accept variable number of sessions * fix type error
…cts (prebid#14171) * Add weakCachec to objectGuard * add unit test * lint --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* Start.io adapter: Change the protocol from http to https * Start.io adapter: Changing content-type to json * Start.io adapter: Changing content-type back to text/plain
…bid#14044) * Add SeenThis Brand Stories module * test: add unit tests for seenthisBrandStories module functions and constants * remove support for loading inside iframe * only allow events of seenthis origin * fix tests; update applying of styling * sort variables * emit billable event on init --------- Co-authored-by: Per Holmäng <per.holmang@gmail.com>
* GreenbidsBidAdapter: fix tests * fix adnuntius & pbsBidAdapter
* Screencore prebid adapter * rearrange code * use lowercase screncore bidder code * fix tests * update tests * trigger CI * Screencore Bid Adapter: add endpointId parameter * Updated adapter to use teqblazeUtils library * Added endpointId parameter support in test parameters * Updated test specs to include endpointId validation * Screencore Bid Adapter: update sync URL to base domain Update SYNC_URL constant to use base domain. The getUserSyncs function from teqblazeUtils will append the appropriate path. * Screencore Bid Adapter: migrate to teqblazeUtils library - Update imports to use buildRequestsBase, interpretResponse, getUserSyncs, isBidRequestValid, and buildPlacementProcessingFunction from teqblazeUtils - Remove storage manager dependency (no longer needed) - Update isBidRequestValid to use placementId/endpointId params validation - Refactor buildRequests to use buildRequestsBase pattern - Rewrite test suite to match teqblazeUtils API: - Simplify test data structures - Update server response format (body as array) - Add tests for placementId/endpointId validation - Update getUserSyncs URL format expectations --------- Co-authored-by: Kostiantyn Karchevsky <kostiantyn.karchevsky@teqblaze.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
…#14197) Co-authored-by: Patrick McCann <patmmccann@gmail.com>
A bitwise `&` was being used instead of the intended `|`.
wi101
approved these changes
Nov 24, 2025
…rebid#14183) * Remove colorDepth data from window dimensions * Remove colorDepth property from winDimensions Removed the colorDepth property from winDimensions object. * Update screen dimensions to null in datablocksBidAdapter Set screen availability width and height to null.
* FS-12392 update adapter * FS-12392 fix test * FS-12392 linting
…-in-the-data-collected-by-the-client-side-analytics-adapter
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
…g during auction (prebid#14214) * Removed spread operator * make test meaningful * Add more tests and adjust logic * lint --------- Co-authored-by: pm-azhar-mulla <azhar@L2047.local> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
…id#14215) * Updated bid adapter to log errors * Remove onBidderError function and LOGGER_JS_URI Removed unused onBidderError function and LOGGER_JS_URI constant. * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Abdou <40374175+disparate1@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Monis Qadri <monis0395@users.noreply.github.com>
…-in-the-data-collected-by-the-client-side-analytics-adapter
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
* drop cdep support * revert change in smartadserver adapter
…id#14129) * ID5 Analytics module - support gzip compression of large events Some of the events we are collecting are really large, and it takes a lot of time to send them over the network uncompressed. By compressing them we can save some bandwidth and also cut the receiving time. * ID5 Analytics module - add check for gzip supported in tests
Co-authored-by: Victor <victor.banudz@smart-hub.io>
…-in-the-data-collected-by-the-client-side-analytics-adapter
* Fix keywords to be sent as array * Add tests
* Adapters: nullify banned device metrics * Add hardwareConcurrency and deviceMemory to bid request * Update greenbidsBidAdapter_specs.js * Update greenbidsBidAdapter_specs.js * Fix indentation and formatting in tests * Remove hardwareConcurrency and deviceMemory tests Removed tests for hardwareConcurrency and deviceMemory from the greenbidsBidAdapter spec.
* zero latency - initial version * WURFL RTD: remove free tier wurfl_id handling * WURFL RTD: update internal version * WURFL RTD: update abSplit to be a float * WURFL RTD: LCE add iOS26 osv logic * WURFL RTD: beacon add tier * WURFL RTD: bump version to 2.0.0 * WURFL RTD: refactor LCE device detection for robustness and error tracking Refactored WurflLCEDevice.FPD() to be more error-resistant and provide better enrichment type tracking for analytics. * WURFL RTD: update LCE_ERROR value * WURFL RTD: bump version to 2.0.1 * WURFL RTD: add is_robot detection * WURFL RTD: refactor LCE device detection for robustness and error tracking * WURFL RTD: initialize bidder fragments if not already present * WURFL RTD: fix ortb2Fragments.bidder merge for Prebid 10.x compatibility * WURFL RTD: bump version to 2.0.3 * WURFL RTD: beacon add over_quota and rename bidder.enrichment to bidder.bdr_enrich * WURFL RTD: improve debug logging * WURFL RTD: bump version to 2.0.5 * WURFL RTD: use global debug flag instead of params.debug * WURFL RTD: optimize payload by moving basic+pub caps to global Optimize ortb2Fragments payload size by enriching global.device.ext.wurfl with basic+publisher capabilities when under quota, instead of duplicating them in every bidder fragment. * WURFL RTD: authorized should not receive pub caps when overquota * WURFL RTD: update module doc to include disclosure about wurfl.js loading
* Added the ability to send floor info for each ad unit size * refactor test * Update floor value in limelightDigitalBidAdapter tests --------- Co-authored-by: Alexander Pykhteyev <alex.pykhteyev@gmail.com> Co-authored-by: Ilia Medvedev <mailbox@imedvedev.com>
…-in-the-data-collected-by-the-client-side-analytics-adapter
|
this has been merged to prebid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information