Keep recent blockhashes in litesvm state#170
Open
MicaiahReid wants to merge 4 commits intoLiteSVM:masterfrom
Open
Keep recent blockhashes in litesvm state#170MicaiahReid wants to merge 4 commits intoLiteSVM:masterfrom
MicaiahReid wants to merge 4 commits intoLiteSVM:masterfrom
Conversation
MicaiahReid
changed the title
Aursen
requested changes
Apr 17, 2025
Collaborator
Aursen
left a comment
Aursen
left a comment
There was a problem hiding this comment.
Seems good to me, you just need to run cargo-fmt
crates/litesvm/src/lib.rs
Outdated
| )])); | ||
| { | ||
| let blockhashes = self.get_sysvar::<RecentBlockhashes>(); | ||
| let mut entries = vec![]; |
Collaborator
There was a problem hiding this comment.
Is it possible to init with capacity, something like this:
let max_entries_len = blockhashes.len().min(MAX_RECENT_BLOCKHASHES);
let mut entries = Vec::with_capacity(max_entries_len);
Collaborator
There was a problem hiding this comment.
We should initialise it in LiteSVM::new and store it as a field on the LiteSVM struct
Contributor
Author
There was a problem hiding this comment.
@Aursen @kevinheavey, I've implemented Aursen's suggested change and run cargo fmt. I'm not quite understanding Kevin's suggestion - is that something either of you will have time to knock out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
expire_blockhashfunction store recent blockhashes in theRecentBlockhashessysvar, rather than throwing them all out every time a new blockhash is created. At mostMAX_RECENT_BLOCKHASHEShashes are stored.Additionally, transaction validation is updated to check if the
recent_blockhashin the transaction method is in the set of recent blockhashes, rather than just checking if it is equal to the latest blockhash.