Skip to content

feat(match2): automatically purge bracket page on matchpage change#7198

Open
ElectricalBoy wants to merge 5 commits intomainfrom
experimental-matchpage-autopurge
Open

feat(match2): automatically purge bracket page on matchpage change#7198
ElectricalBoy wants to merge 5 commits intomainfrom
experimental-matchpage-autopurge

Conversation

@ElectricalBoy
Copy link
Collaborator

Summary

This PR automates purging of tournament page when matchpage is saved.

How did you test this change?

dev + browser dev tools

@ElectricalBoy ElectricalBoy requested a review from a team as a code owner March 3, 2026 12:35
@ElectricalBoy ElectricalBoy added the g: valorant VALORANT label Mar 3, 2026
@ElectricalBoy ElectricalBoy requested a review from a team as a code owner March 3, 2026 12:35
@ElectricalBoy ElectricalBoy added c: match2 g: dota2 DOTA2 g: leagueoflegends League of Legends javascript Changes to JavaScript files labels Mar 3, 2026
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it wise to add this before we have lighthouse?

@ElectricalBoy
Copy link
Collaborator Author

is it wise to add this before we have lighthouse?

check discord

@mbergen mbergen requested a review from FO-nTTaX March 3, 2026 12:56
@FO-nTTaX
Copy link
Member

FO-nTTaX commented Mar 3, 2026

I'm slightly worried about people getting timed out for this, medium-term this is something we probably should do on the backend

@ElectricalBoy
Copy link
Collaborator Author

I think it should be pretty safe from timeouts
purging via mw api would be triggered if you are logged in, working in Match: namespace, and made a (non-touch) save of matchpage

@Rathoz
Copy link
Collaborator

Rathoz commented Mar 3, 2026

Agreed with FO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: match2 g: dota2 DOTA2 g: leagueoflegends League of Legends g: valorant VALORANT javascript Changes to JavaScript files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants