Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tweaks Table2’s highlighted-row styling in light mode by adjusting the base highlight background and the highlighted hover background to new semantic-gold shades.
Changes:
- Updated light-mode highlighted row background color to
--clr-semantic-gold-90. - Updated light-mode highlighted row hover background color to
--clr-semantic-gold-85.
Comments suppressed due to low confidence (1)
stylesheets/commons/Table2.scss:164
--clr-semantic-gold-85appears to be newly introduced here and isn’t referenced/defined anywhere else in the repo. If this CSS custom property isn’t provided by the runtime theme tokens, the hover background-color rule becomes invalid and the highlighted hover state won’t change. Consider using an existing semantic gold token that’s already in use (e.g. -80/-90) or add a fallback value to thevar()call.
&.table2__row--highlighted:hover {
.theme--light & {
background-color: var( --clr-semantic-gold-85 );
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Collaborator
Author
Oh, yes I'm waiting for the new 85 variable to get approved in the skin, that's why this PR is in draft still |
Collaborator
Ah yeah. Make sense 👍 |
FO-nTTaX
approved these changes
Mar 3, 2026
hjpalpha
approved these changes
Mar 3, 2026
Rathoz
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This PR adjusts the highlight color and hover color for the table2 widget in light mode
How did you test this change?
devtools