Skip to content

feat(table2): adjust highlight color#7196

Merged
Eetwalt merged 2 commits intomainfrom
table2-hl-color
Mar 3, 2026
Merged

feat(table2): adjust highlight color#7196
Eetwalt merged 2 commits intomainfrom
table2-hl-color

Conversation

@Eetwalt
Copy link
Collaborator

@Eetwalt Eetwalt commented Mar 3, 2026

Summary

This PR adjusts the highlight color and hover color for the table2 widget in light mode

How did you test this change?

devtools

Copilot AI review requested due to automatic review settings March 3, 2026 09:39
@Eetwalt Eetwalt requested review from a team as code owners March 3, 2026 09:39
@Eetwalt Eetwalt added the stylesheets Changes to stylesheets label Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tweaks Table2’s highlighted-row styling in light mode by adjusting the base highlight background and the highlighted hover background to new semantic-gold shades.

Changes:

  • Updated light-mode highlighted row background color to --clr-semantic-gold-90.
  • Updated light-mode highlighted row hover background color to --clr-semantic-gold-85.
Comments suppressed due to low confidence (1)

stylesheets/commons/Table2.scss:164

  • --clr-semantic-gold-85 appears to be newly introduced here and isn’t referenced/defined anywhere else in the repo. If this CSS custom property isn’t provided by the runtime theme tokens, the hover background-color rule becomes invalid and the highlighted hover state won’t change. Consider using an existing semantic gold token that’s already in use (e.g. -80/-90) or add a fallback value to the var() call.
		&.table2__row--highlighted:hover {
			.theme--light & {
				background-color: var( --clr-semantic-gold-85 );
			}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Eetwalt Eetwalt marked this pull request as draft March 3, 2026 09:48
@SlothyMan
Copy link
Collaborator

For some reason When I set value from 90 to 85 it doesn't work on hover then 🤔

image image

It worked only when I was using .../50/60/70/80/90

Recording.2026-03-03.112935.mp4

@Eetwalt
Copy link
Collaborator Author

Eetwalt commented Mar 3, 2026

For some reason When I set value from 90 to 85 it doesn't work on hover then 🤔

Oh, yes I'm waiting for the new 85 variable to get approved in the skin, that's why this PR is in draft still

@SlothyMan
Copy link
Collaborator

For some reason When I set value from 90 to 85 it doesn't work on hover then 🤔

Oh, yes I'm waiting for the new 85 variable to get approved in the skin, that's why this PR is in draft still

Ah yeah. Make sense 👍

@Eetwalt Eetwalt marked this pull request as ready for review March 3, 2026 11:06
@Eetwalt Eetwalt merged commit 2e53988 into main Mar 3, 2026
7 checks passed
@Eetwalt Eetwalt deleted the table2-hl-color branch March 3, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants