Open
Conversation
it's baseline since 2015, so should be safe to kick entirely
hjpalpha
approved these changes
Mar 1, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
seems reasonable on phone
Rathoz
reviewed
Mar 2, 2026
| $idp1: $id + 1; | ||
| .crosstable.crosstable-col-#{$idp1} td:nth-child(#{$id}) { | ||
| @mixin crosstable-col($max) { | ||
| @for $i from 1 through $max { |
Member
There was a problem hiding this comment.
not sure what you mean with "this"
Member
There was a problem hiding this comment.
If it's about $idp1 then frankly I'm not sure anymore
Collaborator
Author
There was a problem hiding this comment.
we've been using for loop since #7023 and it has been working without issues
Member
There was a problem hiding this comment.
Pretty sure @for loops were never an issue, it was @extend that caused us issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
@includes with@forloopbox-shadowbox-shadowis baseline widely available for over a decade now, so it should be safe to remove all vendor prefix variants@mixinsHow did you test this change?
difftools + browser dev tools