Skip to content

feat: add button for tournament player information to new team cards#6879

Closed
ElectricalBoy wants to merge 4 commits intomainfrom
tpi-button
Closed

feat: add button for tournament player information to new team cards#6879
ElectricalBoy wants to merge 4 commits intomainfrom
tpi-button

Conversation

@ElectricalBoy
Copy link
Collaborator

Summary

Depends on #6870

This PR adds button for the tournament player information query to new teamcards.

How did you test this change?

dev + browser dev tools

@ElectricalBoy ElectricalBoy added c: team_card stylesheets Changes to stylesheets labels Dec 2, 2025
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some wikis might not want the button to show (at least in some events)

also what happens if you have 2+ teamCard sections?

@ElectricalBoy
Copy link
Collaborator Author

some wikis might not want the button to show (at least in some events)

bd5ca35

also what happens if you have 2+ teamCard sections?

wouldn't be a problem as the button would now have to be manually enabled

Base automatically changed from tournament-player-info to main December 10, 2025 10:09
@ElectricalBoy ElectricalBoy marked this pull request as ready for review January 6, 2026 09:16
@ElectricalBoy ElectricalBoy requested a review from Eetwalt January 6, 2026 09:16
@Eetwalt
Copy link
Collaborator

Eetwalt commented Jan 7, 2026

Do you have a dev page for this?

@ElectricalBoy
Copy link
Collaborator Author

Do you have a dev page for this?

https://liquipedia.net/leagueoflegends/User:ElectricalBoy/Sandbox4

@ElectricalBoy ElectricalBoy requested review from a team and removed request for Eetwalt February 3, 2026 04:11
@ElectricalBoy ElectricalBoy requested a review from a team as a code owner March 3, 2026 04:47
@ElectricalBoy
Copy link
Collaborator Author

Closing in favor of #7194

@ElectricalBoy ElectricalBoy deleted the tpi-button branch March 3, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants