Open
Conversation
When (d *dictionary) Lookup() is called on an non-existing key, the `messageKeyToIndex[key]` returns 0. As 0 is also a valid entry in messageKeyToIndex, the method returned the wrong value rather than fail. Fixes golang/go#35587 Change-Id: Iedd1cf42f29335c2c2052b07993d7f2dfcd3cc6c Reviewed-on: https://go-review.googlesource.com/c/text/+/207217 Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
nasjp
force-pushed
the
liquid20200205/follow_upstream_master
branch
from
e28bb02 to
5e6ac7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Liquid-dev/text/pull/1 からブランチを切った。
[https://github.com/golang/text/commit/929e72ca90deac4784bbe451caf10faa5b256ebe](Upstream のコミット) ここまでをマージ。