Open
Conversation
Oliboy50
reviewed
Feb 5, 2020
Contributor
Oliboy50
left a comment
Oliboy50
left a comment
There was a problem hiding this comment.
👏 very good job 👏
thank you ❤️
MicaelMnl
force-pushed
the
feat/core
branch
6 times, most recently
from
147d2ef to
30945a3
Compare
Contributor
|
Thanks for keeping alive this project ❤️ |
MicaelMnl
force-pushed
the
feat/core
branch
4 times, most recently
from
6657246 to
2552cbd
Compare
Oliboy50
reviewed
Feb 11, 2020
| "scripts": { | ||
| "symfony-scripts": [ | ||
| "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters", | ||
| "cp .env.dist .env", |
Contributor
There was a problem hiding this comment.
could we remove "incenteev/composer-parameter-handler" from "require" then?
Contributor
There was a problem hiding this comment.
so... could you do it in this PR, please? 😅
MicaelMnl
force-pushed
the
feat/core
branch
9 times, most recently
from
9df4f9f to
ac2e688
Compare
Oliboy50
reviewed
Feb 18, 2020
| $loader->load(function (ContainerBuilder $container) { | ||
| // Check if webpack dev server is up before using it | ||
| @file_get_contents($container->getParameter('webpack_dev_server_base_url')); | ||
| @file_get_contents($container->resolveEnvPlaceholders($container->getParameter('webpack_dev_server_base_url'), true)); |
Contributor
There was a problem hiding this comment.
Suggested change
| @file_get_contents($container->resolveEnvPlaceholders($container->getParameter('webpack_dev_server_base_url'), true)); | |
| @file_get_contents($container->getParameter('webpack_dev_server_base_url')); |
no need to resolve because we already convert the env variable to a parameter:
webpack_dev_server_base_url: '%env(WEBPACK_DEV_SERVER_BASE_URL)%'and this is a URL, so we don't need to resolve anything 🤔
| 'base_url' => sprintf( | ||
| '%s/%s', | ||
| rtrim($container->getParameter('webpack_dev_server_base_url'), '/'), | ||
| rtrim($container->resolveEnvPlaceholders($container->getParameter('webpack_dev_server_base_url'), true), '/'), |
Contributor
There was a problem hiding this comment.
Suggested change
| rtrim($container->resolveEnvPlaceholders($container->getParameter('webpack_dev_server_base_url'), true), '/'), | |
| rtrim($container->getParameter('webpack_dev_server_base_url'), '/'), |
| "scripts": { | ||
| "symfony-scripts": [ | ||
| "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters", | ||
| "cp .env.dist .env", |
Contributor
There was a problem hiding this comment.
so... could you do it in this PR, please? 😅
| $dotenv = new Dotenv(); | ||
| $dotenv->load(__DIR__.'/../.env'); | ||
|
|
||
| if($_ENV['APP_ENV'] !== 'prod') { |
Contributor
There was a problem hiding this comment.
why don't we just delete this file (app_dev.php), instead of doing weird things like that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
Features: