Adding multisample feature along with testcases#740
Draft
VijayVignesh1 wants to merge 4 commits intoLightning-AI:mainfrom
Draft
Adding multisample feature along with testcases#740VijayVignesh1 wants to merge 4 commits intoLightning-AI:mainfrom
VijayVignesh1 wants to merge 4 commits intoLightning-AI:mainfrom
Conversation
1b01b6f to
6a77302
Compare
Contributor
Author
|
@tchaton @deependujha @bhimrazy Can you verify the approach once? I can then make changes to the README. |
deependujha
reviewed
Oct 29, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
===================================
- Coverage 80% 80% -0%
===================================
Files 52 52
Lines 7343 7357 +14
===================================
- Hits 5885 5876 -9
- Misses 1458 1481 +23 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #317
PR review
Added support for multisample item.
Basically added a sample_count parameter which creates a batch of sub samples for each sample, given a single transform function.
Sample code:
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃