Open
Conversation
glbert-does
force-pushed
the
fix_channel_creation_tests
branch
from
1c4ef69 to
b48858d
Compare
Member
Author
|
this still works as well (unsurprisingly), rebased on current master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we previously fixed failing team creation tests by forcing an order of team channels in the tests. that made failing tests less likely, but failures still occur because the task itself does not use ordered teams. change this to force the same order.
in fairness, it would probably be better to improve the test conditions. but this is easier.
while at it, lazily add some typing to the task function.