-
Notifications
You must be signed in to change notification settings - Fork 17
[Editor/Vim] Update Vim syntax highlighting to match current version #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Editor/Vim] Update Vim syntax highlighting to match current version #98
Conversation
| \ void | ||
|
|
||
| syn keyword glintPrimitiveTypes | ||
| \ Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they have to be capitalized? In lexer.cc, tests and examples they're all lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They used to have to be, but they no longer are; IIRC I left it because I meant to make everything case-insensitive, but never got around to it. bool, byte, etc is the proper "modern" Glint styling for built-in types
|
I haven't tested lambdas at all yet, I'll add some cases for it and make sure it's working. A lambda is basically supposed to act like
This PR looks good, and I'd merge it unless you want to add anything else |
|
There is a list of keywords in |
There are some test cases for lambdas now; they appear to be working afaik? |
I'm not entirely sure what else to add and would appreciate corrections. So far, I'm only sure about
cfor,csize, andcusize.As far as I understand,
lambda,has,typeof,true, andfalsearen't used anywhere, but they seem to have implementations (thoughlambdadoesn't work for me, but maybe I'm using it incorrectly).