Open
Conversation
Contributor
|
I wanted to use the latest version of java to see if there were new language features could be useful for solving this problem. Thanks for making it simpler to switch |
Contributor
|
just realized I don't have write access to this repo so @isidore will need to accept this pull request I think |
isidore
pushed a commit
that referenced
this pull request
Aug 28, 2020
…sts-approvaltests-9.3.0 Bump approvaltests from 2.0.1 to 9.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few groups ran into a problem when changing from java 11 to java 8. It had to be changed in 3 places. It seems to me that the use of the maven-compiler-plugin configuration is no necessary given the two options in the section. I removed them, it works fine for me switching between java 11 and 8.
Just in case: @emilybache was there some specific reason to add the 11 and the specific version of maven-compiler-plugin?