Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Update prefixfree.dynamic-dom.js#176

Open
simonkcleung wants to merge 3 commits intoLeaVerou:gh-pagesfrom
simonkcleung:patch-1
Open

Update prefixfree.dynamic-dom.js#176
simonkcleung wants to merge 3 commits intoLeaVerou:gh-pagesfrom
simonkcleung:patch-1

Conversation

@simonkcleung
Copy link

Fix to #120

@LeaVerou
Copy link
Owner

LeaVerou commented Jan 5, 2016

Hi there,
Thanks and sorry for the huge delay. What is this PR about? There seems to be very little explanation and a very large diff.

@simonkcleung
Copy link
Author

Line 58, Line 63

Checking (prefixed in proto) is not correct because proto is not a list of CSS properties.

The prototype of style "proto"
in Chrome/Edge: document.documentElement.style.constructor = CSSStyleDeclaration(){}
in FF: CSS2Properties(){}
in IE: MSStyleCSSProperties(){}

List of CSS properties: Object.getOwnPropertyNames of
in FF: proto.prototype
in Chrome/IE: document.documentElement.style

Setting of unprefixed properties to proto:

Prefix in FF is e.g. MozAnimation
in Chrome : webkitAnimation
in Edge: webkitAnimation and msAnimation???
in IE: msAnimation

Need further review for Edge.

The getter and setter functions could be placed outside the for loop for better performance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants