feat: Added the raw attribute to dataclasses #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new attribute stores the raw json of the api response for this object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unknown/unexpected or not implemented values should still be accessible. Waiting for the maintainers to implement such a small thing is annoying.
resolves #7
Implementation
All datamodel classes should have a
raw(or some equivalent) attribute which stores the raw json response data for this object.The
rawattribute is not meant to be used over the direct attributes. It is meant to be a fallback solution if things are not yet implemented.Changes
Added:
Component.rawFacility.rawAddress.rawTimeWindowDay.rawTimeWindowPhase.rawNotificationOverview.rawNotificationSubmissionState.rawUserData.raw(just like theFroeling._userdataobject, this does not update on auto-reauth)Added tests for these
rawattributes.