Fix cooldown swipe direction: decide per icon category#27
Open
choppaoops wants to merge 1 commit into
Open
Conversation
Fix cooldown swipe direction: decide per icon category
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ApplyCooldownSwipesets the swipe reverse from a single globalreverseActiveSwipetoggle. No single value is correct for every icon, becausethe categories want different directions:
SCMBuffOptions) read best counting downbright → dark — the dark swipe grows as the buff expires.
already shrinks to show remaining time. They must not be reversed —
reversing makes the highlight grow instead of shrink.
With one global flag, enabling it fixes buff icon viewers but flips the active
swipe the wrong way; disabling it does the reverse. There is no setting that gets
both right.
Fix
Decide the reverse value from the icon category instead of the global flag. Only
buff icon viewers reverse; icons showing an active aura and icons on cooldown keep
the default direction:
Color handling (
recolorActiveSwipe,recolorNormalSwipe, the color pickers,disableRegularIconActiveSwipe) is unchanged — this only touches direction.Notes
reverseActiveSwipeoption is no longer read; its checkbox can be removedfrom the options panel (or kept as a no-op). No defaults change is required.
dark→bright, buff icon viewers sweep bright→dark, and the native active swipe
shrinks correctly.