Feature: Keybinds

[SekSion]

Hey!
Adding here Keybinds which might be niche for some players but in my case i enjoy it, i tried to make it in a way that by default is disabled, and it should't run or impact anything, turning it on or off will unregister the events so it completly shuts down or turns on any required scans or functions.

I did take inspiration by other addons but i do not believe there is much to go around with it, let me know what you think.

I also thought of adding a way to make it hide the keybind per each spell/icon/trink but i do not see a use case for it unless players would hide/show just for defensives or potions or something...
Also works with macros so far as i tested.

[toanqc]

I love this feature. I'm currently pulling this PR down and use.

I found a bug, though.

Here is the step to reproduce:

1. Enable the Keybinds
2. Mount up (Dragon Riding) - which means the action bar 1 is changed to the Dragon Riding abilities)
3. Move 1 ability to a different action bar slot (or move 1 new spell from the spellbook to the action bar)
4. The keybinds repaint, and some are gone. I also dismounted, and the keybinds are not showing back.

[SekSion]

hmm dam going to check i thought the paging event would solve that mostly

[SekSion]

I can't reproduce that exactly, tho, some are disappearing because its changing the action bar 1 but even moving spells from and into it seems to be properly updating unless some other issue occoured and broke it, but so far i see nothing o.o

recording.mp4

[toanqc]

Here is how I reproduce it

keybind_issue.mp4

Also, I display stack on the bottom and the keybind somehow covers it. I don't have a suggestion on how to fix it, though. I think I can live with it (keybind Z)

[SekSion]

Your using elv ui or some other addon that replaces the action bars? could be that probably, will take a look when i can only thing i can think of is that it could be some override, i also use stacks on bottom right and i have no overlaps so might be something small

[toanqc]

I'm using ElvUI, but I disabled the CD skin. I just disabled everything and only enabled SkironCooldownManager, I still have the problem.

[SekSion]

Tried a few changes to try and fix the issue which i 100% cannot replicate on my side :( may take a while to fix that, and about the Text overlap of the keybind i tried to fix which is by adding a strata level config but the problem is that reducing the strata by one would make it disappear entirely below all the icons , so that would require a change on other places and not just keybind which i don't wanna do at the moment since the Maintainers might not want this merged..

[Lardeck]

Thanks for the pull request. I will take a closer look over the next couple of days. I'm not against a feature like that. I will probably do a code review and request some changes tomorrow or on Monday.

[SekSion]

Did some changes to try and mitigate conflicts, trying to do as less as possible changes outside of the keybinds.lua

[toanqc]

@SekSion can we skip the repaint/re-render when the character is in the skyriding or in the vehicle? That's way we don't lose the keybinding that is already rendered before.

e.g I have my keybindig rendered, I'm going to skyriding or abyss anglers, use an action then the keybinds are gone (especially for the 1-5 keybind)

[SekSion]

Yee that is an issue with action bar 1 changing, i've been struggling a bit with it currently cause there is always one case where it doenst work as intended :/

[SekSion]

@toanqc Made a push with some changes i think now it works properly and in a state i enjoy let me know if something else catchs your eyes!

[Lardeck]

Hey, sorry for not helping a lot here. It's a large feature and I didn't have the time yet to look at all the code. I will try to get to it this week but I can't promise.

[SekSion]

Its fine for me! i mostly just use it for me, and try to keep updated with whatever you do, been using it daily in all content with multiple classes and i dont see any particular issue or errors popping from it