Skip to content

go: use def result.Close() idiom in tests#9

Merged
adsharma merged 2 commits intomasterfrom
finalizer_fixes
Mar 2, 2026
Merged

go: use def result.Close() idiom in tests#9
adsharma merged 2 commits intomasterfrom
finalizer_fixes

Conversation

@adsharma
Copy link
Copy Markdown
Contributor

Also return nil on error paths

@adsharma
Copy link
Copy Markdown
Contributor Author

adsharma commented Mar 2, 2026

@aheev @jkumz: connection_test.go:65 has intermittent errors. Passes after a few re-runs. Don't know if it was pre-existing or caused by this defer idiom.

@adsharma adsharma merged commit 5506d9f into master Mar 2, 2026
5 of 16 checks passed
@adsharma adsharma deleted the finalizer_fixes branch March 2, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant