Skip to content

Associate rate types with payment methods #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labkey-jeckels merged 4 commits into from
Jan 15, 2026
Merged

Associate rate types with payment methods #1162

labkey-jeckels merged 4 commits into from
Jan 15, 2026

Conversation

@labkey-jeckels
Copy link
Contributor

@labkey-jeckels labkey-jeckels commented Jan 10, 2026 •
edited
Loading

Rationale

Different types of payment are associated with different hourly and setup rates.

Changes

  • Let admins explicitly define this for each payment method
  • Delete rows when containers are deleted and add FK to avoid orphaning rows in the future
  • Fix metadata on simple lookups to targetedms schema
  • Adjust data shown in tooltips in instrument schedule calendars

@labkey-jeckels labkey-jeckels self-assigned this Jan 10, 2026
@github-actions
Copy link

github-actions bot commented Jan 10, 2026

ERROR: A pull request from 25.11_fb_paymentMethodRateType is expected to target release25.11-SNAPSHOT, not develop

@labkey-jeckels labkey-jeckels changed the base branch from develop to release25.11-SNAPSHOT January 10, 2026 01:23
@labkey-jeckels labkey-jeckels merged commit a29f91f into release25.11-SNAPSHOT Jan 15, 2026
0 of 2 checks passed
@labkey-jeckels labkey-jeckels deleted the 25.11_fb_paymentMethodRateType branch January 15, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankurjuneja ankurjuneja ankurjuneja approved these changes

Assignees

@labkey-jeckels labkey-jeckels

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labkey-jeckels @ankurjuneja