Search engine, page-navigator#5
Open
kgogola wants to merge 4 commits into
Open
Conversation
Collaborator
|
What . means? |
kwojcik-blockether
requested changes
Apr 15, 2018
| @@ -0,0 +1,29 @@ | |||
| <template> | |||
Collaborator
There was a problem hiding this comment.
Could you name it like Navigation.vue or sth like that? Components should start from the capital letter than CamelCase should be used.
| }, | ||
| computed: { | ||
| booksFiltered: function () { | ||
| return this.$store.state.books.filter((book) => { |
Collaborator
There was a problem hiding this comment.
filter(book => book.title.match(this.search))
Collaborator
Author
|
@FieryCod sorry for this '.' etc in my commits, I ve got battle with Github Deskopt :/ |
Collaborator
|
Please change those commits names. |
LaYatiX
requested changes
Apr 22, 2018
LaYatiX
left a comment
LaYatiX
left a comment
Owner
There was a problem hiding this comment.
Please update changes and style what you have added. To speed up styling you can add bootstrap
I included some style of this main navigator (using bootstrap).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I included page-navigator in layouts to get around all page and search engine. It will be possible to add some books to "favourites" catalog (i will add this option in next task)