Small correction to MetaFortress addresses for "Kirby Mass Attack"#184
Merged
Gericom merged 2 commits intoMay 29, 2026
Merged
Conversation
62cfb72 to
563cd47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes four addresses for Kirby Mass Attack's MetaFortress patches which are not actually MetaFortress checksums, they are DS Protect checksums produced by inlines. See https://github.com/taxicat1/dsprot/blob/2.01/dsprot.h#L101
The DS Protect patching does not require these be removed.
These are the addresses (for all regions):
02000CE5,02000D1B,02000D4F,02000D85. Nowhere else in the game does DS Protect appear to ever be called.Removing these has no real function besides technically saving 64 bytes off the patchlist, primarily I just want the MetaFortress address list to be accurate.
Also adds some random other comment doc corrections/additions about MetaFortress