You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it might be a good idea to pass the ssl cert key to TwlAes::SetupAes (you could pass a null pointer if it could not be found or so) and then call aes_setKeySlot(0) (and possibly aes_waitKeyBusy() near the point where the arm7 is booted. This makes sure that most of the responsibility is in the TwlAes class and avoids repeating some code (most of what you are doing in SetupKeySlot does already happen in SetupAes)
I think it might be a good idea to pass the ssl cert key to TwlAes::SetupAes (you could pass a null pointer if it could not be found or so) and then call aes_setKeySlot(0) (and possibly aes_waitKeyBusy() near the point where the arm7 is booted. This makes sure that most of the responsibility is in the TwlAes class and avoids repeating some code (most of what you are doing in SetupKeySlot does already happen in SetupAes)
It seems that sslcertkey needs to be set after both ARM9i and ARM7i decryption are completed.
Trying to pass it to key slot 0 earlier does not work.
I think it might be a good idea to pass the ssl cert key to TwlAes::SetupAes (you could pass a null pointer if it could not be found or so) and then call aes_setKeySlot(0) (and possibly aes_waitKeyBusy() near the point where the arm7 is booted. This makes sure that most of the responsibility is in the TwlAes class and avoids repeating some code (most of what you are doing in SetupKeySlot does already happen in SetupAes)
It seems that sslcertkey needs to be set after both ARM9i and ARM7i decryption are completed. Trying to pass it to key slot 0 earlier does not work.
You should be able to set the key regardless. It doesn't suddenly disappear.
I think it might be a good idea to pass the ssl cert key to TwlAes::SetupAes (you could pass a null pointer if it could not be found or so) and then call aes_setKeySlot(0) (and possibly aes_waitKeyBusy() near the point where the arm7 is booted. This makes sure that most of the responsibility is in the TwlAes class and avoids repeating some code (most of what you are doing in SetupKeySlot does already happen in SetupAes)
It seems that sslcertkey needs to be set after both ARM9i and ARM7i decryption are completed. Trying to pass it to key slot 0 earlier does not work.
You should be able to set the key regardless. It doesn't suddenly disappear.
I found an alternative approach to avoid repeating code.
It has been tested, works as expected, and does not break any existing functionality.
I just don't understand why setting your ssl keyslot requires a different approach than setting the other key slots
I can understand if AES needs an extra reset or something to activate the keyslot maybe and that is fine, but that can probably be done in NdsLoader.cpp just before booting
Also another important thing is that we should not do any file IO anymore after performing the arm7 patches
The key should be setup in the same way as the other keys in the SetupAes function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.