-
Notifications
You must be signed in to change notification settings - Fork 0
Increase language selector spacing from viewport edge #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ export default function Home() { | |
| <div className="animated-gradient" aria-hidden="true" /> | ||
|
|
||
| {/* Language selector - top right */} | ||
| <div className="fixed top-4 right-4 z-20 sm:top-6 sm:right-6"> | ||
| <div className="fixed top-6 right-6 z-20 sm:top-8 sm:right-8"> | ||
| <div className="language-selector"> | ||
|
Comment on lines
19
to
21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2 | Confidence: High The change is a straightforward, low-risk CSS spacing adjustment. It correctly implements the described intent (increasing the distance from the viewport edge) on both mobile (top-4→top-6, right-4→right-6) and desktop breakpoints (sm:top-6→sm:top-8, sm:right-6→sm:right-8). No functional logic, API signatures, or architectural patterns are affected. All existing CI checks passed, and no undefined edge cases are introduced. The change is consistent and does not introduce technical debt or regressions. No further review actions are required. |
||
| <select | ||
| id="language-select" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Pre-existing aria-label version mismatch
The
aria-labelon line 46 reads "Version 0.13 Beta" while the visible text on line 47 reads "Version: 0.14 β". This discrepancy means screen readers will announce an outdated version number. This is a pre-existing issue (not introduced by this PR) but worth noting for a follow-up fix.(Refers to lines 46-47)
Was this helpful? React with 👍 or 👎 to provide feedback.