-
Notifications
You must be signed in to change notification settings - Fork 0
Update version label to 0.14 β #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -47,7 +47,7 @@ export default function Home() { | |||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| {/* Version label - bottom right */} | ||||||||||||||||||||||||
| <div className="version-label" aria-label="Version 0.13 Beta"> | ||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. WARNING: The |
||||||||||||||||||||||||
| Version: 0.13 Beta | ||||||||||||||||||||||||
| Version: 0.14 β | ||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Comment on lines
49
to
+50
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 aria-label still says "Version 0.13 Beta" while visible text was updated to "Version: 0.14 β" The
Suggested change
Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 Info: Greek letter β used instead of "Beta" — potential rendering concern The visible text changed from the English word Was this helpful? React with 👍 or 👎 to provide feedback. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: The visible version text was updated to Severity Level: Major
|
||||||||||||||||||||||||
| <div className="version-label" aria-label="Version 0.13 Beta"> | |
| Version: 0.13 Beta | |
| Version: 0.14 β | |
| <div className="version-label" aria-label="Version 0.14 β"> | |
| Version: 0.14 β | |
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aria-label ("Version 0.13 Beta") and the visible version string ("Version: 0.14 β") are inconsistent. This can confuse users of assistive technologies and introduces accessibility issues. Ensure both values are synchronized, ideally by referencing a single source of truth for the version string.
Recommended solution:
- Store the version in a constant or configuration file and use it for both the visible label and the
aria-label. - Example:
const version = "0.14 β"; <div className="version-label" aria-label={`Version ${version}`}>Version: {version}</div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Align visible version text and aria-label for accuracy and accessibility.
The visible text shows
0.14 βbut thearia-labelis stillVersion 0.13 Beta, which will cause screen readers to announce a different version than what sighted users see. Please update thearia-labelto the new version and consider using a consistent textual form (e.g.,Version 0.14 Beta) for better assistive technology support.