Skip to content

Make it work with Factorio 2.0#135

Open
erplsf wants to merge 8 commits intoL0laapk3:devfrom
erplsf:dev
Open

Make it work with Factorio 2.0#135
erplsf wants to merge 8 commits intoL0laapk3:devfrom
erplsf:dev

Conversation

@erplsf
Copy link
Copy Markdown

@erplsf erplsf commented Jun 4, 2025

Tested on Windows by running on an early-game, Space Age save so I couldn't check the multiple if surfaces, planets or ships are broken.

These changes aim to close #133 and to close #123.

Supersedes #134 as that was done against master branch instead of dev.

@L0laapk3
Copy link
Copy Markdown
Owner

L0laapk3 commented Jun 4, 2025

Code changes look good to me.

I tested it on a few saves:

I will do some investigative work and keep you up to date. If you want, feel free to reach out on discord, I can be found in the factorio server.

@erplsf
Copy link
Copy Markdown
Author

erplsf commented Jun 4, 2025

Thanks!

@L0laapk3
Copy link
Copy Markdown
Owner

L0laapk3 commented Jun 4, 2025

The access violation was already fixed in 2.0.48 on the experimental branch. There seem to be some issues still when snapshotting multiple surfaces at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants