Open
Conversation
This is now available dynamically, as per https://forums.factorio.com/viewtopic.php?p=595577#p595577
This closes L0laapk3#123.
This closes L0laapk3#133.
Owner
|
Code changes look good to me. I tested it on a few saves:
I will do some investigative work and keep you up to date. If you want, feel free to reach out on discord, I can be found in the factorio server. |
Author
|
Thanks! |
Owner
|
The access violation was already fixed in 2.0.48 on the experimental branch. There seem to be some issues still when snapshotting multiple surfaces at once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on Windows by running on an early-game, Space Age save so I couldn't check the multiple if surfaces, planets or ships are broken.
These changes aim to close #133 and to close #123.
Supersedes #134 as that was done against
masterbranch instead ofdev.