Decouple listRunners-outage backstop window from the zombie-reap interval#44
Merged
Merged
Conversation
…rval PR #43 review (Copilot): the runner-API outage backstop reused neverConfirmedReapInterval as its "sustained" threshold, coupling two independent behaviors — tuning or disabling the zombie reaper would silently widen or disable the outage backstop and could re-enable the runaway scale-up during a prolonged outage. Give the backstop its own listRunnersOutageHoldInterval (default 120s). Also document neverConfirmedReapInterval's value semantics: a negative value disables the reaper; a very small value (e.g. 0) reaps a runner before it can come online (test-only) — the production default leaves a real connect window. OrchestratorTests 37 passing; build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the two Copilot comments on #43 (both valid):
Orchestrator.swift): the runner-API outage backstop reusedneverConfirmedReapIntervalas its "sustained outage" threshold, so tuning/disabling the zombie reaper would silently change (or disable) the backstop window — which could re-enable the runaway scale-up that caused the original pileup. The backstop now has its ownlistRunnersOutageHoldInterval(default 120s), independent of the reaper.neverConfirmedReapIntervaldisables the reaper, and that a very small value (e.g. 0) reaps a runner before it can come online (test-only) — the production default leaves a real connect window.No behavior change at the defaults (both 120s). OrchestratorTests 37 passing; build clean. Folds into the v0.1.3 release (the in-flight v0.1.3 build was cancelled and the tag will be re-cut from
mainafter this merges — nothing was published).