Skip to content

Feature/sale indicator on Products#2

Open
KyleO249 wants to merge 4 commits into
mainfrom
feature/sale-indicators
Open

Feature/sale indicator on Products#2
KyleO249 wants to merge 4 commits into
mainfrom
feature/sale-indicators

Conversation

@KyleO249

@KyleO249 KyleO249 commented Aug 22, 2023

Copy link
Copy Markdown
Owner

Added the ability to indicate when a product is on sale:
image

@KyleO249 KyleO249 requested a review from keaganbester August 22, 2023 16:57
@KyleO249 KyleO249 self-assigned this Aug 22, 2023
@KyleO249 KyleO249 closed this Aug 22, 2023
@KyleO249 KyleO249 reopened this Aug 22, 2023
Comment thread .vscode/tasks.json
"version": "2.0.0",
"tasks": [
{
"label": "start",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the linter to correct this whitespace

Comment thread src/app/product-list/product-list.component.css Outdated
Comment thread src/app/product-list/product-list.component.css Outdated

@keaganbester keaganbester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments

Co-authored-by: Keagan Bester <keaganbester@gmail.com>
Comment thread .vscode/launch.json
"type": "chrome",
"request": "launch",
"name": "Launch Chrome against localhost",
"url": "http://localhost:4200",

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"url": "http://localhost:4200",
"url": "http://localhost:4201",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants