Skip to content

Fix Glama MCP startup#167

Merged
simongonzalezdc merged 1 commit into
mainfrom
fix-glama-mcp-startup
Jun 4, 2026
Merged

Fix Glama MCP startup#167
simongonzalezdc merged 1 commit into
mainfrom
fix-glama-mcp-startup

Conversation

@simongonzalezdc
Copy link
Copy Markdown
Member

@simongonzalezdc simongonzalezdc commented Jun 4, 2026

Summary\n- start the Glama Docker image through the package's real dist entrypoint instead of the npm bin symlink\n- make the MCP package entrypoint guard symlink-safe for future package releases\n\n## Verification\n- pnpm --filter @dialectos/mcp build\n- pnpm --filter @dialectos/mcp test\n- MCP client handshake against node packages/mcp/dist/index.js returned 17 tools


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 255de106-a40c-4b3d-8a03-117a921bd9ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-glama-mcp-startup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@simongonzalezdc simongonzalezdc merged commit 628d4d5 into main Jun 4, 2026
9 checks passed
@simongonzalezdc simongonzalezdc deleted the fix-glama-mcp-startup branch June 4, 2026 01:29
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ace2b58058

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/mcp/src/index.ts
}

try {
return import.meta.url === pathToFileURL(realpathSync(entrypoint)).href;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle preserve-symlinks-main bin launches

When users launch the package bin symlink with NODE_OPTIONS=--preserve-symlinks-main or node --preserve-symlinks-main, Node keeps import.meta.url as the symlink URL while this check compares it only to the realpath target, so isCurrentFileEntrypoint() returns false and main() never starts, leaving MCP clients without a handshake. The old guard succeeded in that mode; compare against both the realpath URL and the original entrypoint URL.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant