chore(deps): bump actions/upload-artifact from 4.6.2 to 7.0.1#2
Open
dependabot[bot] wants to merge 1 commit into
Open
chore(deps): bump actions/upload-artifact from 4.6.2 to 7.0.1#2dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
937b40f to
eb6f8aa
Compare
McSpace
pushed a commit
that referenced
this pull request
Jun 4, 2026
…ncel text Two audit-3 follow-ups: 1. `field-fontFamily` — the previous override `'Courier New, monospace'` never rasterised in the Playwright Chromium image (the font isn't installed and the stack fell through to the headless default sans-serif), so the visual audit kept flagging the tooltip text as proportional even though the DOM-verify's family-string match passed. Swap the override to `'Times New Roman, serif'` — Times New Roman ships with most Chromium font sets, and the trailing `serif` generic guarantees a visually-distinct serif render on any platform. Update the verify assertion to match. 2. `field-tooltipCancelButtonTextColor` — audit #3 read the Cancel label as "clearly white on dark grey" and reclassified it as a real bug. A runtime DOM probe (computed `color` and inline `style.color`) confirmed the override IS applied — the text is black, identical issue to the previously-fixed Select-button case (audit #2 also misread it). Add a DOM-verify that pins computed `color` to `rgb(0, 0, 0)`, mirroring the Select sibling — visual LLMs cannot discriminate near-invisible black text on baseline dark-grey, and the DOM is the ground truth here. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
McSpace
pushed a commit
that referenced
this pull request
Jun 6, 2026
In tooltipOnHover mode `onSeatMouseLeave` synchronously cleared `activeTooltip`, so the Select / Cancel / Close-X buttons inside the tooltip were already gone from the DOM by the time the cursor reached them — making rule #2 of the builtInTooltip × tooltipOnHover matrix unreachable in practice. `onSeatMouseLeave` now schedules a deferred close (300 ms grace window). `(mouseenter)` on `<sm-jets-tooltip>` and the override host wrapper cancels the pending close, `(mouseleave)` re-arms it, and a re-entering `_showTooltip` aborts a stale close so bouncing back to the seat doesn't kill the just-reopened tooltip. `ngOnDestroy` clears the timer to avoid a stray `activeTooltipChanged(null)` emit after teardown. 300 ms was picked over the WCAG-branch's 80 ms after an e2e demo spec caught the cursor crossing the 12 px seat→tooltip gap slower than 80 ms at normal speeds. Tests: 5 new unit tests (deferred close, mouseenter cancels, mouseleave re-arms, re-entry aborts, destroy clears timer) plus a Playwright e2e suite in `tooltipHoverClickable/` covering the click-the-Cancel-button contract and the seat→tooltip→seat round-trip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.2 to 7.0.1. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...043fb46) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
eb6f8aa to
b8ed859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 4.6.2 to 7.0.1.
Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
043fb46Merge pull request #797 from actions/yacaovsnc/update-dependency634250cInclude changes in typespec/ts-http-runtime 0.3.5e454baaReadme: bump all the example versions to v7 (#796)74fad66Update the readme with direct upload details (#795)bbbca2dSupport direct file uploads (#764)589182cUpgrade the module to ESM and bump dependencies (#762)47309c9Merge pull request #754 from actions/Link-/add-proxy-integration-tests02a8460Add proxy integration testb7c566aMerge pull request #745 from actions/upload-artifact-v6-releasee516bc8docs: correct description of Node.js 24 support in README