Skip to content

Disable v8 control flow integrity #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kudo wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Disable v8 control flow integrity #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8907b6
test
Kudo Apr 23, 2023
c41d33f
bump version
Kudo Apr 24, 2023
af13006
fix missing snapshot from publishing
Kudo Apr 25, 2023
6930510
bump version [skip ci]
Kudo Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"version": "11.110.1",
"version": "11.110.3",
"workspaces": [
"packages/*"
],
Expand Down
4 changes: 2 additions & 2 deletions packages/v8-android-jit-nointl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "v8-android-jit-nointl",
"version": "11.110.1",
"version": "11.110.3",
"description": "Pre-build version of V8 to be used by React Native apps",
"repository": {
"type": "git",
Expand All @@ -18,6 +18,6 @@
},
"homepage": "https://github.com/Kudo/v8-android-buildscripts#readme",
"files": [
"dist/"
"dist/**/*"
]
}
4 changes: 2 additions & 2 deletions packages/v8-android-jit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "v8-android-jit",
"version": "11.110.1",
"version": "11.110.3",
"description": "Pre-build version of V8 to be used by React Native apps",
"repository": {
"type": "git",
Expand All @@ -18,6 +18,6 @@
},
"homepage": "https://github.com/Kudo/v8-android-buildscripts#readme",
"files": [
"dist/"
"dist/**/*"
]
}
4 changes: 2 additions & 2 deletions packages/v8-android-nointl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "v8-android-nointl",
"version": "11.110.1",
"version": "11.110.3",
"description": "Pre-build version of V8 to be used by React Native apps (Non Intl supported version)",
"repository": {
"type": "git",
Expand All @@ -18,6 +18,6 @@
},
"homepage": "https://github.com/Kudo/v8-android-buildscripts#readme",
"files": [
"dist/"
"dist/**/*"
]
}
2 changes: 1 addition & 1 deletion packages/v8-android-tools-linux/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "v8-android-tools-linux",
"version": "11.110.1",
"version": "11.110.3",
"description": "Tools for v8-android",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/v8-android-tools-macos/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "v8-android-tools-macos",
"version": "11.110.1",
"version": "11.110.3",
"description": "Tools for v8-android",
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions packages/v8-android/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "v8-android",
"version": "11.110.1",
"version": "11.110.3",
"description": "Pre-build version of V8 to be used by React Native apps",
"repository": {
"type": "git",
Expand All @@ -18,6 +18,6 @@
},
"homepage": "https://github.com/Kudo/v8-android-buildscripts#readme",
"files": [
"dist/"
"dist/**/*"
]
}
2 changes: 1 addition & 1 deletion scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ if [[ ${PLATFORM} = "ios" ]]; then
GN_ARGS_BASE="${GN_ARGS_BASE} enable_ios_bitcode=false use_xcode_clang=true ios_enable_code_signing=false v8_enable_pointer_compression=false ios_deployment_target=\"${IOS_DEPLOYMENT_TARGET}\" v8_control_flow_integrity=false v8_enable_lite_mode=true"
elif [[ ${PLATFORM} = "android" ]]; then
# Workaround v8 sysroot build issues with custom ndk
GN_ARGS_BASE="${GN_ARGS_BASE} use_sysroot=false"
GN_ARGS_BASE="${GN_ARGS_BASE} use_sysroot=false v8_control_flow_integrity=false"
fi

if [[ ${NO_INTL} = "true" ]]; then
Expand Down
2 changes: 1 addition & 1 deletion scripts/publish.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def main():
args = parse_args()
workdir = os.path.join(ROOT_DIR, "build", "publish")
publish_engines(args, workdir)
publish_tools_macos(args, workdir)
# publish_tools_macos(args, workdir)

create_engines_zip(args, workdir)
create_tools_zip_macos(args, workdir)
Expand Down