chore: untrack generated base.css, build it in test/CI#58
Merged
Conversation
base.css is a Tailwind build artifact already listed in .gitignore, but it had been tracked since it was first committed (gitignore can't untrack an already-tracked file), so it kept getting re-committed against intent. Untrack it to match js/dist (the TS artifact, also gitignored + untracked). Because nothing in the test path rebuilt it, e2e/static serving relied on the committed copy. Add 'css' (and 'ts') as prerequisites of the test/test-e2e make targets and a Build CSS step in CI so the stylesheet is generated before tests run. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Staging deployment: https://timetracker-staging-chore-untrack-base-css.fly.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
games/static/base.cssis a Tailwind build artifact. It's listed in.gitignore(line 23), but it had been tracked since it was first committed — and.gitignoreonly affects untracked files, so it kept getting re-committed against intent (111 commits touched it). This came up after #57, wheremake css+git add base.csssilently re-committed the regenerated file.js/dist/(the TypeScript artifact) is gitignored and untracked — that's the modelbase.cssshould follow.What
git rm --cached games/static/base.css— untrack it (file stays on disk;.gitignorenow actually applies).make testrebuilt the CSS, so e2e/static serving relied on the committed copy. Addedcss(andts) as prerequisites of thetest/test-e2emake targets.Build CSSstep (make css) before tests — CI previously built TS but not CSS, relying on the committed file.Verification
Simulated a fresh checkout (
rm games/static/base.css), thenmake check→ thecssprereq regenerated it and 534 tests pass.🤖 Generated with Claude Code