Merged
Conversation
AUDIT SUMMARY: - 22 files violate hard size limits (6,000+ lines removable) - SparkConsole.cpp: 6,996 lines (17.5x over 400-line limit) → 4,000+ lines of embedded UI that should be in SparkConsole.exe → 52 Register*Commands methods scattered (limit: 1 per subsystem) - PhysicsSystem.h: 1,909 lines (9.5x over 200-line limit) - RenderGraph.h: 1,730 lines (8.6x over 200-line limit) - ConsoleProcessManager: built but never initialized or called → Fix: 15 min, 3 lines of code - SimpleConsole::Initialize() called 3+ times at different paths → Consolidate to single startup call KNOWLEDGE BASE ENTRIES: 1. codebase-bloat-audit-2026-03-14.md — Full audit with metrics 2. sparkconsole-refactor-plan.md — 2-session refactor plan 3. consoleprocessmanager-wiring.md — Quick fix for unwired system All findings logged in persistent context database with clear refactoring guidance and success criteria. Ready for next session. https://claude.ai/code/session_01GN8Vd4E8VtwkQj75aaqoui
NEW FINDINGS: Dead utility headers (1,052 lines, 0 usages — delete immediately): - ChromeTracing.h (211 lines): macros never called anywhere - MemoryDebugger.h (433 lines): SPARK_TRACK_ALLOC/FREE/LEAK never called - FrameInspector.h (408 lines): GetInstance() never called ODR risk: - Two classes named AudioMixer in same namespace Spark::Audio (AudioMixer.h + MusicManager.h line 57) — rename MusicManager's internal class to AudioBusMixer Duplicate startup paths (SparkEngine.cpp): - PhysicsSystem created 5× across startup paths (should be 1) - GraphicsEngine created 3× across startup paths (should be 1) - console.Initialize() called 3× (should be 1) - Root cause: each startup variant copy-pastes rather than calling shared InitCoreSystems() — ~600 removable lines Two parallel visual scripting systems (7,343 combined lines): - VisualScriptSystem (engine): 2,406 lines — Init() possibly unwired - VisualScriptingSystem (editor): 4,937 lines — node types duplicated Shader.cpp: duplicate #include at line 1298 (harmless, indicates the file was spliced together) Updated index.md with P0/P1/P2 priority ordering. Running total removable lines: ~8,650 https://claude.ai/code/session_01GN8Vd4E8VtwkQj75aaqoui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.