Performance bump in PSTH #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. JIT histogram and searchsorted via Numba 3. dropna() in histogram Together, these changes speed up PSTH 3x on my machine
Author
|
Currently the failing test seems to do with tensorflow version. It's probably enough to pin TF to 2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single-threaded speedup through JIT histograms and parallelization over neurons. This introduces numba and joblib dependencies, but there is an option to turn off parallelization. If it's turned off, joblib is not imported. -1 option means use all available threads.
On Steinmetz Neuropix dataset, this gets a 3x single-threaded speed increase and theoretically linear speed increase with the number of threads
Tests are passing, except for strf:
TypeError: object of type <class 'float'> cannot be safely interpreted as an integer.but I think that's unrelated since this PR does not deal with ML part. Edit: Fixed that test, indeed it wasn't related to this PR.